solution #1603
Open
solution #1603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
witflash
suggested changes
Aug 22, 2023
This reverts commit c6146ed.
witflash
suggested changes
Aug 22, 2023
src/App.jsx
Outdated
| <p className="Person__partner">Natasha is my wife</p> | ||
| </section> | ||
| <Person | ||
| className="Person__name" |
There was a problem hiding this comment.
You don't need to use the className prop here because:
- you don't use this prop in
Personcomponent; - you have already used this class inside
PersonJSX.
src/components/Person/Person.jsx
Outdated
| { | ||
| person.isMarried ? ( | ||
| <p className="Person__partner"> | ||
| {person.sex === 'm' ? ( |
There was a problem hiding this comment.
It's a bad practice to use nested ternary operators.
You can separate this logic into two parts. First: create variable const marriedStatus = person.sex === 'm' ? ... : .... Second: use ternary here in JSX:
<p className="Person__partner">{person.isMarried ? marriedStatus : 'I am not married'}</p>
There was a problem hiding this comment.
still not fixed, you are duplicating tag <p>
sTorba24
suggested changes
Aug 22, 2023
src/components/Person/Person.jsx
Outdated
| { | ||
| person.isMarried ? ( | ||
| <p className="Person__partner"> | ||
| {person.sex === 'm' ? ( |
There was a problem hiding this comment.
still not fixed, you are duplicating tag <p>
sTorba24
suggested changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://denys2.github.io/react_person/